Skip to content

Avoid ICEs after bad patterns, for the other syntactic variants #150979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 15, 2026
Merged

Avoid ICEs after bad patterns, for the other syntactic variants #150979

rust-bors merged 1 commit into from
Jan 15, 2026
+128 −9

Conversation

@meithecatte
Copy link
Contributor

@meithecatte meithecatte commented Jan 11, 2026 •
edited by rustbot
Loading

This PR introduces changes equivalent to the ones in #126320, but also for struct and tuple patterns, instead of tuple struct patterns only.

Fixes #150507.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@meithecatte
Copy link
Contributor Author

meithecatte commented Jan 11, 2026

cc @oli-obk @lcnr – feels like the struct case in particular is something that fell through the cracks during the original PR, could be an interesting pattern to look for in reviews.

lcnr
lcnr reviewed Jan 14, 2026
View reviewed changes
lcnr
lcnr reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nit

View changes since this review

@lcnr
Copy link
Contributor

lcnr commented Jan 15, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 15, 2026

📌 Commit 1028c7a has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2026
@Zalathar Zalathar mentioned this pull request Jan 15, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 15, 2026
@bors
Auto merge of #151158 - Zalathar:rollup-okXJcXA, r=Zalathar
7704328 
Rollup of 4 pull requests

Successful merges:

 - #150846 (include `HirId`s directly in the THIR, not wrapped in `LintLevel`s)
 - #150979 (Avoid ICEs after bad patterns, for the other syntactic variants)
 - #151103 (mir_build: Simplify length-determination and indexing for array/slice patterns)
 - #151130 (resolve: Downgrade `ambiguous_glob_imports` to warn-by-default)

r? @ghost
@rust-bors rust-bors bot merged commit 9682509 into rust-lang:main Jan 15, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 15, 2026
rust-timer added a commit that referenced this pull request Jan 15, 2026
@rust-timer
Unrolled build for #150979
b39f74f 
Rollup merge of #150979 - typeck-pat, r=lcnr

Avoid ICEs after bad patterns, for the other syntactic variants

This PR introduces changes equivalent to the ones in #126320, but also for struct and tuple patterns, instead of tuple struct patterns only.

Fixes #150507.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

ICE: Field projection applied to a type other than Adt or Tuple: !.

4 participants

@meithecatte @rustbot @lcnr @fee1-dead