Skip to content

Conversation

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jan 3, 2026

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Ayush1325 and others added 4 commits December 19, 2025 22:38
Add support for binding and accepting TCP4 connections.

While testing, the following network options were used with QEMU + OVMF:
-nic user,hostfwd=tcp::12345-:12345

The default localhost address on qemu seems to be 10.0.2.15.

UEFI spec does not seem to state that the TCP Handle returned by the
Accept method has a ServiceBinding Protocol. So have made the
ServiceBinding Protocol optional.

Signed-off-by: Ayush Singh <ayush@beagleboard.org>
…ss35

std: sys: net: uefi: tcp: Initial TcpListener support

Add support for binding and accepting TCP4 connections.

While testing, the following network options were used with QEMU + OVMF: -nic user,hostfwd=tcp::12345-:12345

The default localhost address on qemu seems to be 10.0.2.15.

UEFI spec does not seem to state that the TCP Handle returned by the Accept method has a ServiceBinding Protocol. So have made the ServiceBinding Protocol optional.

cc `@nicholasbishop`
std: remove manual bindings on NetBSD

These have been added to `libc`, so there's no need to redefine them in `std`.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 3, 2026
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

📌 Commit 1fe83d5 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
bors added a commit that referenced this pull request Jan 3, 2026
Rollup of 2 pull requests

Successful merges:

 - #145339 (std: sys: net: uefi: tcp: Initial TcpListener support)
 - #150641 (std: remove manual bindings on NetBSD)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Jan 3, 2026

⌛ Testing commit 1fe83d5 with merge 79128b6...

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 3, 2026
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
fmt check
fmt: checked 6619 files
tidy check

thread 'deps (.)' (3866) panicked at src/tools/tidy/src/deps.rs:654:24:
cmd.exec() failed with `cargo metadata` exited with an error:     Updating crates.io index
    Updating git repository `https://github.com/rust-lang/team`
error: failed to get `rust_team_data` as a dependency of package `site v0.1.0 (/checkout/src/tools/rustc-perf/site)`

Caused by:
  failed to load source for dependency `rust_team_data`

Caused by:
  Unable to update https://github.com/rust-lang/team#a5260e76

Caused by:
  failed to clone into: /cargo/git/db/team-679b79b2e58466cd

Caused by:
  revision a5260e76d3aa894c64c56e6ddc8545b9a98043ec not found

Caused by:
---
   5: std::thread::scoped::scope::<rust_tidy::main::{closure#4}, ()>
   6: rust_tidy::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Bootstrap failed while executing `--stage 2 test --skip tests --skip coverage-map --skip coverage-run --skip library --skip tidyselftest`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 yarn` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/tool.rs:1612:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1357:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:00:46
  local time: Sat Jan  3 14:10:02 UTC 2026
  network time: Sat, 03 Jan 2026 14:10:02 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@matthiaskrgr
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2026
@bors
Copy link
Collaborator

bors commented Jan 3, 2026

⌛ Testing commit 1fe83d5 with merge 1d22b96...

@bors
Copy link
Collaborator

bors commented Jan 3, 2026

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 1d22b96 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 3, 2026
@bors bors merged commit 1d22b96 into rust-lang:main Jan 3, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 3, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#145339 std: sys: net: uefi: tcp: Initial TcpListener support 8a9a707c76a86e9ceaeaa1c985a4ba73af7d9430 (link)
#150641 std: remove manual bindings on NetBSD ffa1473dae422c4fbfaafd333343cb0772d7f141 (link)

previous master: 4c3310a6db

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c3310a (parent) -> 1d22b96 (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1d22b964dfa858eeb7a74ee3d8c06adfcd79d702 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. i686-gnu-1: 8155.1s -> 6840.6s (-16.1%)
  2. test-various: 7857.1s -> 6602.2s (-16.0%)
  3. pr-check-2: 2621.6s -> 2269.6s (-13.4%)
  4. x86_64-gnu-tools: 3678.1s -> 3229.5s (-12.2%)
  5. x86_64-rust-for-linux: 3119.0s -> 2740.8s (-12.1%)
  6. x86_64-gnu-gcc: 3422.2s -> 3013.7s (-11.9%)
  7. pr-check-1: 1878.1s -> 1657.7s (-11.7%)
  8. aarch64-gnu-llvm-20-1: 3724.6s -> 3346.9s (-10.1%)
  9. i686-gnu-2: 5927.4s -> 5336.4s (-10.0%)
  10. dist-apple-various: 3935.0s -> 3543.6s (-9.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d22b96): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.6% [-5.6%, -5.6%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.071s -> 473.382s (-0.15%)
Artifact size: 390.82 MiB -> 390.84 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants