region_scope_tree: Rewrite a loop as tail recursion
#150548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 1, 2026
…uwer Rollup of 4 pull requests Successful merges: - #149778 (`crate::io::Result` → `io::Result` in most places) - #150264 (split up tracking issue for target feature feature gates) - #150548 (`region_scope_tree`: Rewrite a `loop` as tail recursion) - #150555 (Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 1, 2026
Rollup merge of #150548 - dianne:temp-scope-extension-loop-rewrite, r=BoxyUwU `region_scope_tree`: Rewrite a `loop` as tail recursion This addresses #146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible. I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s. r? BoxyUwU or anyone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #146098 (comment), hopefully making
record_subexpr_extended_temp_scopesa bit more legible.I removed a
debug!in the process, since the function it calls every iteration,ScopeTree::record_extended_temp_scope, does the samedebug!. Keeping the behavior of having an additionaldebug!for the top-level expression would hurt legibility, and having a duplicatedebug!at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the innerdebug!s.r? BoxyUwU or anyone