Remove feature(string_deref_patterns)
#150530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in match checking cc @Nadrieril Some changes occurred in match lowering cc @Nadrieril |
rustbot
added
S-waiting-on-review
Collaborator
Zalathar
force-pushed
the
string-deref-patterns
branch
from
3a55a84 to
4ac5492
Compare
Zalathar
commented
Dec 31, 2025
Zalathar
force-pushed
the
string-deref-patterns
branch
from
4ac5492 to
694b707
Compare
Zalathar
force-pushed
the
string-deref-patterns
branch
from
694b707 to
ef8d943
Compare
Member
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Dec 31, 2025
…jackh726 Remove `feature(string_deref_patterns)` The older `string_deref_patterns` feature has been superseded by the newer and more general `deref_patterns` feature. Removing string-deref-patterns allows us to get rid of a few tricky special cases in match lowering, which are different from the special cases used by deref-patterns. The handful of existing tests for `string_deref_patterns` have been migrated to use `deref_patterns` instead. Current nightly users of the older feature should hopefully be able to migrate to the newer feature without too much trouble. Note that `deref_patterns` is currently marked as an “incomplete” feature, because it doesn't have an accepted RFC. But `string_deref_patterns` doesn't appear to have ever had an accepted RFC either, so arguably it should have been marked incomplete too. --- - Tracking issue for both features: rust-lang#87121 - Original implementation: rust-lang#98914 - [Zulip thread: Can we remove `#![feature(string_deref_patterns)]`?](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Can.20we.20remove.20.60.23!.5Bfeature.28string_deref_patterns.29.5D.60.3F/with/565787352)
bors
added a commit
that referenced
this pull request
Dec 31, 2025
…uwer Rollup of 5 pull requests Successful merges: - #146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly) - #150337 (docs: fix typo in std::io::buffered) - #150530 (Remove `feature(string_deref_patterns)`) - #150543 (`rust-analyzer` subtree update) - #150544 (Use --print target-libdir in run-make tests) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Dec 31, 2025
Rollup merge of #150530 - Zalathar:string-deref-patterns, r=jackh726 Remove `feature(string_deref_patterns)` The older `string_deref_patterns` feature has been superseded by the newer and more general `deref_patterns` feature. Removing string-deref-patterns allows us to get rid of a few tricky special cases in match lowering, which are different from the special cases used by deref-patterns. The handful of existing tests for `string_deref_patterns` have been migrated to use `deref_patterns` instead. Current nightly users of the older feature should hopefully be able to migrate to the newer feature without too much trouble. Note that `deref_patterns` is currently marked as an “incomplete” feature, because it doesn't have an accepted RFC. But `string_deref_patterns` doesn't appear to have ever had an accepted RFC either, so arguably it should have been marked incomplete too. --- - Tracking issue for both features: #87121 - Original implementation: #98914 - [Zulip thread: Can we remove `#![feature(string_deref_patterns)]`?](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Can.20we.20remove.20.60.23!.5Bfeature.28string_deref_patterns.29.5D.60.3F/with/565787352)
github-actions bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Jan 1, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly) - rust-lang/rust#150337 (docs: fix typo in std::io::buffered) - rust-lang/rust#150530 (Remove `feature(string_deref_patterns)`) - rust-lang/rust#150543 (`rust-analyzer` subtree update) - rust-lang/rust#150544 (Use --print target-libdir in run-make tests) r? `@ghost` `@rustbot` modify labels: rollup
fee1-dead
reviewed
Jan 2, 2026
Comment on lines
-383
to
-388
| ## `tests/ui/deref-patterns/`: `#![feature(deref_patterns)]` and `#![feature(string_deref_patterns)]` | ||
|
|
||
| Tests for `#![feature(deref_patterns)]` and `#![feature(string_deref_patterns)]`. See [Deref patterns | The Unstable book](https://doc.rust-lang.org/nightly/unstable-book/language-features/deref-patterns.html). | ||
|
|
||
| **FIXME**: May have some overlap with `tests/ui/pattern/deref-patterns`. | ||
|
|
Member
There was a problem hiding this comment.
It might have been nice to rename this section to describe tests/ui/pattern/deref-patterns instead
github-actions bot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jan 8, 2026
…uwer Rollup of 5 pull requests Successful merges: - rust-lang/rust#146798 (RISC-V: Implement (Zkne or Zknd) intrinsics correctly) - rust-lang/rust#150337 (docs: fix typo in std::io::buffered) - rust-lang/rust#150530 (Remove `feature(string_deref_patterns)`) - rust-lang/rust#150543 (`rust-analyzer` subtree update) - rust-lang/rust#150544 (Use --print target-libdir in run-make tests) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older
string_deref_patternsfeature has been superseded by the newer and more generalderef_patternsfeature. Removing string-deref-patterns allows us to get rid of a few tricky special cases in match lowering, which are different from the special cases used by deref-patterns.The handful of existing tests for
string_deref_patternshave been migrated to usederef_patternsinstead. Current nightly users of the older feature should hopefully be able to migrate to the newer feature without too much trouble.Note that
deref_patternsis currently marked as an “incomplete” feature, because it doesn't have an accepted RFC. Butstring_deref_patternsdoesn't appear to have ever had an accepted RFC either, so arguably it should have been marked incomplete too.#![feature(string_deref_patterns)]?