Skip to content

Don't use matches! when == suffices #150405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 27, 2025
Merged

Don't use matches! when == suffices #150405

bors merged 1 commit into from
Dec 27, 2025

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Dec 26, 2025 •
edited by rustbot
Loading

In the codebase we sometimes use matches! for values that can actually just be compared. Replace them with ==.

Subset of #149933.

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred to constck

cc @fee1-dead

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2025
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Don't use matches! when == suffices
9f566f2 
In the codebase we sometimes use `matches!` for values that can actually just be compared. Replace them with `==`.
@estebank estebank force-pushed the matches-could-be-equals branch from f77875a to 9f566f2 Compare December 26, 2025 20:28
Kivooeo
Kivooeo approved these changes Dec 26, 2025
View reviewed changes
Copy link
Member

@Kivooeo Kivooeo left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but honestly it's so unusual to read pattern matching with a ==, when I find matches! more familiar

If this is what we are in favour to, because as far as I understand previous discussion ended on that we want to use == instead of matches!, then yeah, let's do it, I guess i will get used to it pretty fast

View changes since this review

@oli-obk
Copy link
Contributor

oli-obk commented Dec 27, 2025

I personally prefer using if let. matches! feels like a hack due to no chaining support in earlier Rust. See also my comment in #149933 (comment)

@Kivooeo
Copy link
Member

Kivooeo commented Dec 27, 2025

r? me

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 27, 2025

📌 Commit 9f566f2 has been approved by Kivooeo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2025
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 27, 2025
Merged
bors added a commit that referenced this pull request Dec 27, 2025
@bors
Auto merge of #150430 - JonathanBrouwer:rollup-seh9m66, r=JonathanBro…
4c67064 
…uwer

Rollup of 2 pull requests

Successful merges:

 - #150393 (Document relative and absolute paths handling in `--remap-path-prefix`)
 - #150405 (Don't use `matches!` when `==` suffices)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d63068b into rust-lang:main Dec 27, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 27, 2025
@rust-timer
Unrolled build for #150405
f4cac24 
Rollup merge of #150405 - estebank:matches-could-be-equals, r=Kivooeo

Don't use `matches!` when `==` suffices

In the codebase we sometimes use `matches!` for values that can actually just be compared. Replace them with `==`.

Subset of #149933.
@rustbot rustbot added this to the 1.94.0 milestone Dec 27, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 28, 2025
@bors
Auto merge of #150430 - JonathanBrouwer:rollup-seh9m66, r=JonathanBro…
01fe329 
…uwer

Rollup of 2 pull requests

Successful merges:

 - rust-lang/rust#150393 (Document relative and absolute paths handling in `--remap-path-prefix`)
 - rust-lang/rust#150405 (Don't use `matches!` when `==` suffices)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kivooeo Kivooeo Kivooeo approved these changes

Assignees

@Kivooeo Kivooeo

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@estebank @rustbot @rust-log-analyzer @oli-obk @Kivooeo @bors @fee1-dead