Use realstd current thread static variables in tests #150131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Member
|
r=me with a rebase Can you clarify why this should be beta-nominated? It's not clear to me what regression it's fixing. |
Mark-Simulacrum
added
S-waiting-on-author
sardok
force-pushed
the
realstd_thread_variables
branch
from
6b430c3 to
abbbd77
Compare
This comment has been minimized.
This comment has been minimized.
Author
|
Thanks for the review. The stdlib's cc: @Mark-Simulacrum (don't have the privileges for bors commands) |
Collaborator
|
@sardok: 🔑 Insufficient privileges: Not in reviewers |
Contributor
|
@Mark-Simulacrum can you please take a look at the PR? This is (still) failing in nightly, and the beta release is approaching quickly. |
Member
|
@bors r+ |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-author
Mark-Simulacrum
added
the
beta-nominated
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
…imulacrum Use realstd current thread static variables in tests Fixes rust-lang#150053. This PR basically exports `thread::current::CURRENT` & `thread::current::ID*` static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred as `readlstd::...` in `test_internals` module. If approved, i would kindly ask this PR to be beta nominated. Thank you.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
…imulacrum Use realstd current thread static variables in tests Fixes rust-lang#150053. This PR basically exports `thread::current::CURRENT` & `thread::current::ID*` static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred as `readlstd::...` in `test_internals` module. If approved, i would kindly ask this PR to be beta nominated. Thank you.
Contributor
|
Checking for the failure at #150856 (comment) @bors2 try jobs=aarch64-gnu-llvm-20-1 |
Contributor
|
Unknown command "2". Run |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jan 9, 2026
Use realstd current thread static variables in tests try-job: aarch64-gnu-llvm-20-1
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 9, 2026
…imulacrum Use realstd current thread static variables in tests Fixes rust-lang#150053. This PR basically exports `thread::current::CURRENT` & `thread::current::ID*` static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred as `readlstd::...` in `test_internals` module. If approved, i would kindly ask this PR to be beta nominated. Thank you.
Contributor
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 10, 2026
…imulacrum Use realstd current thread static variables in tests Fixes rust-lang#150053. This PR basically exports `thread::current::CURRENT` & `thread::current::ID*` static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred as `readlstd::...` in `test_internals` module. If approved, i would kindly ask this PR to be beta nominated. Thank you.
Member
|
Investigating failure in rollup: #150914 (comment) @bors try jobs=aarch64-gnu-llvm-20-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Jan 10, 2026
Use realstd current thread static variables in tests try-job: aarch64-gnu-llvm-20-1
Member
|
Hmm, looks like I wasn't the first person to suspect this PR for that failure, and the previous try job was fine. Maybe the failure is flaky? I'll re-run a try job on the rollup that failed, to double-check. |
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for fbb646e failed: CI. Failed jobs:
|
Contributor
|
@bors r- |
Contributor
|
Commit abbbd77 has been unapproved. |
rust-bors
bot
removed
the
S-waiting-on-bors
sardok
force-pushed
the
realstd_thread_variables
branch
from
abbbd77 to
a5fb2de
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Author
|
I've been looking into the As far as I can see, the test runner crashes during io:: tests, which suggests the thread ID refactoring in this PR might be the cause. @Mark-Simulacrum, how should I proceed? Does it make sense to restrict the thread ID refactoring to the SGX target? cc @davidtwco as lead of the aarch64-unknown-linux-gnu target. |
|
I was able to reproduce a failure locally on my M1 Mac using the command In CI, As I understand it, there are two implementations of |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150053. This PR basically exports
thread::current::CURRENT&thread::current::ID*static variables and be referred to them when testing. I also added a minor refactoring which collects symbols referred asreadlstd::...intest_internalsmodule.If approved, i would kindly ask this PR to be beta nominated.
Thank you.