Add const cloning of slices and tests #147938
Merged
+94
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
Collaborator
|
☔ The latest upstream changes (presumably #147957) made this pull request unmergeable. Please resolve the merge conflicts. |
Randl
force-pushed
the
const-clone-slice
branch
from
f12698c to
d7b7f2c
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #135634) made this pull request unmergeable. Please resolve the merge conflicts. |
Randl
force-pushed
the
const-clone-slice
branch
from
d7b7f2c to
c1472c5
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@tgross35 should I request review from someone else? |
tgross35
approved these changes
Jan 11, 2026
Contributor
|
Sorry, this hasn't been on my radar. It would have been fine to reroll. We have been more cautious than previously with constifying things that require const traits, especially given we're not much closer to stabilization. But this is reasonably fundamental and the hack isn't all that bad, so I think it is fine to accept. @bors r+ rollup |
rust-bors
bot
added
S-waiting-on-bors
Contributor
jdonszelmann
added a commit
to jdonszelmann/rust
that referenced
this pull request
Jan 11, 2026
Add const cloning of slices and tests As discussed in rust-lang#143628 (comment), splitting off slice cloning as a separate PR. r? @tgross35
rust-bors bot
added a commit
that referenced
this pull request
Jan 11, 2026
Rollup of 7 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150723 (std: move `errno` and related functions into `sys::io`) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 11, 2026
Add const cloning of slices and tests As discussed in rust-lang#143628 (comment), splitting off slice cloning as a separate PR. r? @tgross35
rust-bors bot
added a commit
that referenced
this pull request
Jan 11, 2026
Rollup of 7 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
rust-bors bot
added a commit
that referenced
this pull request
Jan 12, 2026
Rollup of 9 pull requests Successful merges: - #147938 (Add const cloning of slices and tests) - #149718 (Add freeze file times on Windows) - #150438 (Remove mentions of debootstrap and chroots from the m68k-unknown-none-elf platform support doc) - #150790 (feat: invisible character help string) - #150906 (Simplify `#[eii]` macro using methods on ecx) - #150938 (Port `#[collapse_debuginfo]` to the new attribute parsing system) - #150953 (std: sys: fs: uefi: Implement copy) - #150964 (Completely list all unparsed attributes) - #150975 (ui: add test for normalizing const projections with assoc const equality) Failed merges: - #150972 (Rename EII attributes slightly (being consistent in naming things foreign items, not extern items)) r? @ghost
rust-timer
added a commit
that referenced
this pull request
Jan 12, 2026
Rollup merge of #147938 - const-clone-slice, r=tgross35 Add const cloning of slices and tests As discussed in #143628 (comment), splitting off slice cloning as a separate PR. r? @tgross35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #143628 (comment), splitting off slice cloning as a separate PR.
r? @tgross35