minimal dirfd implementation (1/4) #146341

Qelxiros · 2025-09-08T17:32:07Z

This is the first of four smaller PRs that will eventually be equivalent to #139514.

A few notes:

I renamed new to open because open_dir takes &self and opens a subdirectory.
- I also renamed open to open_file.
I'm not sure how to impl AsRawFd and friends because the common implementation uses PathBufs. How should I proceed here?

The other PRs will be based on this one, so I'll make drafts and mark them ready as their predecessors get merged. They might take a bit though; I've never done this particular thing with git before.

Tracking issue: #120426

r? @tgross35

try-job: aarch64-apple
try-job: dist-various*
try-job: test-various*
try-job: x86_64-msvc-1
try-job: x86_64-mingw*

library/std/src/sys/fs/common.rs

library/std/src/sys/fs/uefi.rs

library/std/src/sys/fs/unsupported.rs

library/std/src/fs.rs

library/std/src/sys/fs/windows.rs

tgross35 · 2025-09-10T03:01:20Z

@ChrisDenton I'll need your help for the Windows review

library/std/src/sys/fs/unix.rs

Qelxiros · 2025-09-10T17:19:09Z

@rustbot ready

tgross35

Looks pretty good to me, just a few mechanical things here. There are a couple left over from the previous review, #146341 (comment), #146341 (comment), and (newly) #146341 (comment).

View changes since this review

library/std/src/sys/fs/unix/dir.rs

library/std/src/sys/fs/unsupported.rs

library/std/src/sys/fs/unix.rs

library/std/src/sys/fs/windows.rs

library/std/src/sys/fs/unix.rs

library/std/src/sys/fs/windows/dir.rs

tgross35 · 2025-09-10T21:19:14Z

library/std/src/sys/fs/windows/dir.rs

+    let mut handle = ptr::null_mut();
+    let mut io_status = c::IO_STATUS_BLOCK::PENDING;
+    let access = opts.get_access_mode()? | c::SYNCHRONIZE;
+    let options = create_options | c::FILE_SYNCHRONOUS_IO_NONALERT;


Could you add a note about why this flag is set?

I no longer remember why I chose this one, and looking at it now, I'm not sure whether we should set this one, FILE_SYNCHRONOUS_IO_ALERT, or neither. Maybe @ChrisDenton has thoughts?

Update, using neither causes an error, so I've added back FILE_SYNCHRONOUS_IO_NONALERT

Yeah, passing this flag is equivalent to not passing FILE_FLAG_OVERLAPPED to CreateFile. So if you don't pass this flag, other APIs using the handle need to follow the usual overlapped rules, otherwise they may behave improperly.

tgross35 · 2025-09-10T21:24:27Z

From the top post:

* I'm not sure how to `impl AsRawFd` and friends because the `common` implementation uses `PathBuf`s. How should I proceed here?

I think it would be fine to include the impl AsRawFd only in unix/dir so it's only implemented if we have dirfd. I'll add an unresolved question to the tracking issue.

The other PRs will be based on this one, so I'll make drafts and mark them ready as their predecessors get merged. They might take a bit though; I've never done this particular thing with git before.

That is quite alright, there is no hurry :) For reference, the --update-refs rebase flag can be pretty useful when you're working with a stack (e.g. https://andrewlock.net/working-with-stacked-branches-in-git-is-easier-with-update-refs/)

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

rustbot · 2026-01-03T20:46:38Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tgross35 · 2026-01-03T21:35:37Z

@bors2 try jobs=dist-x86_64-netbsd

minimal dirfd implementation (1/4) try-job: dist-x86_64-netbsd

rust-bors · 2026-01-03T23:13:09Z

☀️ Try build successful (CI)
Build commit: b99ccc9 (b99ccc98e2bbe90c252d13c5983c8109e640ee51, parent: 1d22b964dfa858eeb7a74ee3d8c06adfcd79d702)

tgross35 · 2026-01-04T08:20:43Z

@bors r+ rollup=iffy

bors · 2026-01-04T08:20:46Z

📌 Commit d236b8a has been approved by tgross35

It is now in the queue for this repository.

bors · 2026-01-04T10:12:50Z

⌛ Testing commit d236b8a with merge f8b1d59...

bors · 2026-01-04T13:33:46Z

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing f8b1d59 to main...

github-actions · 2026-01-04T13:36:36Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f280e76 (parent) -> f8b1d59 (this PR)

Test differences

Show 303 test diffs

Stage 1

fs::tests::test_dir_read_file: [missing] -> pass (J0)
fs::tests::test_dir_smoke_test: [missing] -> pass (J0)

Stage 2

fs::tests::test_dir_read_file: [missing] -> pass (J1)
fs::tests::test_dir_smoke_test: [missing] -> pass (J1)

Additionally, 299 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f8b1d59a81c700cb7aa25cf69e3032b3ce333150 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 8512.8s -> 6600.9s (-22.5%)
dist-aarch64-apple: 7136.0s -> 5551.6s (-22.2%)
dist-powerpc-linux: 5650.6s -> 4765.6s (-15.7%)
i686-msvc-1: 9526.3s -> 10902.0s (+14.4%)
dist-arm-linux-gnueabi: 4649.6s -> 5271.1s (+13.4%)
aarch64-apple: 8644.7s -> 9719.4s (+12.4%)
pr-check-1: 1506.0s -> 1660.5s (+10.3%)
x86_64-msvc-ext1: 7858.8s -> 7162.4s (-8.9%)
aarch64-gnu: 7977.3s -> 7281.4s (-8.7%)
dist-armv7-linux: 5406.1s -> 4943.4s (-8.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-04T14:14:30Z

Finished benchmarking commit (f8b1d59): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.2%, -0.0%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.0%, 2.3%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[-2.3%, 2.3%]	3

Cycles

Results (secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[3.0%, 3.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.288s -> 475.255s (0.20%)
Artifact size: 390.82 MiB -> 390.83 MiB (0.00%)

PR rust-lang#146341 introduced a compilation error. This fixes it.

Motor OS: fix compile error PR rust-lang#146341 introduced a compilation error. This fixes it.

Rollup merge of #150684 - moturus:main, r=jhpratt Motor OS: fix compile error PR #146341 introduced a compilation error. This fixes it.

rustbot assigned tgross35 Sep 8, 2025

rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 8, 2025

Qelxiros force-pushed the dirfd-minimum branch from c3278f6 to 6982a46 Compare September 8, 2025 17:37

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 6982a46 to 313c731 Compare September 8, 2025 18:26

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 313c731 to 1b3d7d6 Compare September 8, 2025 18:55

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from 1b3d7d6 to be0d761 Compare September 9, 2025 15:09

tgross35 requested changes Sep 10, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2025

tgross35 requested a review from ChrisDenton September 10, 2025 03:01

Qelxiros force-pushed the dirfd-minimum branch from be0d761 to 3083d58 Compare September 10, 2025 17:17

Qelxiros commented Sep 10, 2025

View reviewed changes

library/std/src/sys/fs/unix.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 10, 2025

tgross35 reviewed Sep 10, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 10, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

0ac54d6

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 10, 2025

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

ba649e4

minimal dirfd implementation (1/4) try-job: aarch64-apple try-job: dist-various* try-job: test-various* try-job: x86_64-msvc* try-job: x86_64-mingw*

Qelxiros force-pushed the dirfd-minimum branch from 3ac2b51 to f019942 Compare January 3, 2026 20:50

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the dirfd-minimum branch from f019942 to 6bc1fb2 Compare January 3, 2026 21:27

rust-bors bot added a commit that referenced this pull request Jan 3, 2026

Auto merge of #146341 - Qelxiros:dirfd-minimum, r=<try>

b99ccc9

minimal dirfd implementation (1/4) try-job: dist-x86_64-netbsd

This comment has been minimized.

Sign in to view

Add Dir::open(_file) and some trait impls

d236b8a

Qelxiros force-pushed the dirfd-minimum branch from 6bc1fb2 to d236b8a Compare January 3, 2026 23:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 4, 2026

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026

bors merged commit f8b1d59 into rust-lang:main Jan 4, 2026
12 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

bors mentioned this pull request Jan 4, 2026

Win: Fix std::fs::rename failing on Windows Server by attempting the non-atomic rename first #138133

Open

bors mentioned this pull request Jan 4, 2026

fix: from FIXME(#24570) added more info #148156

Open

Qelxiros mentioned this pull request Jan 4, 2026

dirfd file operations (2/4) #150679

Open

lasiotus added a commit to moturus/rust that referenced this pull request Jan 5, 2026

Motor OS: fix compile error

3f1dd92

PR rust-lang#146341 introduced a compilation error. This fixes it.

lasiotus mentioned this pull request Jan 5, 2026

Motor OS: fix compile error #150684

Merged

the8472 mentioned this pull request Jan 5, 2026

Tracking Issue for directory handles #120426

Open

6 tasks

jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 5, 2026

Rollup merge of rust-lang#150684 - moturus:main, r=jhpratt

d788ec5

Motor OS: fix compile error PR rust-lang#146341 introduced a compilation error. This fixes it.

rust-timer added a commit that referenced this pull request Jan 5, 2026

Unrolled build for #150684

a19b48a

Rollup merge of #150684 - moturus:main, r=jhpratt Motor OS: fix compile error PR #146341 introduced a compilation error. This fixes it.

Uh oh!

minimal dirfd implementation (1/4) #146341

minimal dirfd implementation (1/4) #146341

Uh oh!

Conversation

Qelxiros commented Sep 8, 2025 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Sep 10, 2025

Uh oh!

Uh oh!

Qelxiros commented Sep 10, 2025

Uh oh!

tgross35 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Sep 10, 2025

Uh oh!

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

rustbot commented Jan 3, 2026

Uh oh!

This comment has been minimized.

tgross35 commented Jan 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Jan 3, 2026

Uh oh!

tgross35 commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 4, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 4, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Uh oh!

Reviewers

Qelxiros commented Sep 8, 2025 •

edited by tgross35

Loading

tgross35 left a comment •

edited

Loading