Stabilize `fmt::from_fn` #145915

coolreader18 · 2025-08-27T05:42:33Z

Resolves #146705, pending its FCP.

As discussed in that tracking issue and #117729, this splits fmt::from_fn out from the debug_closure_helpers feature.

rustbot · 2025-08-27T05:42:38Z

r? @thomcc

rustbot has assigned @thomcc.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kobzol · 2025-08-27T07:07:57Z

r? libs-api

bors · 2025-08-30T05:33:42Z

☔ The latest upstream changes (presumably #146023) made this pull request unmergeable. Please resolve the merge conflicts.

jmillikin · 2025-09-01T04:59:55Z

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I would be thrilled to have someone with sufficient permissions start an FCP for debug_closure_helpers.

coolreader18 · 2025-09-01T17:29:51Z

(1) My understanding is that stabilizing a feature requires an FCP, which hasn't yet happened for the linked feature.

I think that's true, but I was imagining that the FCP would just happen here.

(2) It's not clear to me that any resistence to the feature as-is exists, so maybe the whole thing could be stabilized without needing to separate out from_fn?

I'd be fine with that - hopefully someone will start an FCP there.

coolreader18 · 2025-09-01T17:39:52Z

I'm closing this for now with the idea that the full feature will hopefully get FCP'd.

bors · 2025-09-27T08:07:47Z

☔ The latest upstream changes (presumably #146636) made this pull request unmergeable. Please resolve the merge conflicts.

dtolnay

Thank you!

View changes since this review

dtolnay · 2025-11-04T00:43:49Z

@bors r+

bors · 2025-11-04T00:43:52Z

📌 Commit 93c8bf1 has been approved by dtolnay

It is now in the queue for this repository.

…, r=dtolnay Stabilize `fmt::from_fn` Resolves rust-lang#146705, pending its FCP. As discussed in that tracking issue and rust-lang#117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.

Rollup of 10 pull requests Successful merges: - #133149 (Provide more context on `Fn` closure modifying binding) - #143037 (Make named asm_labels lint not trigger on hexagon register spans) - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`) - #145915 (Stabilize `fmt::from_fn`) - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool) - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`) - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored) - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`) - #148448 (Update books) - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`) r? `@ghost` `@rustbot` modify labels: rollup

…, r=dtolnay Stabilize `fmt::from_fn` Resolves rust-lang#146705, pending its FCP. As discussed in that tracking issue and rust-lang#117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.

Rollup of 9 pull requests Successful merges: - #133149 (Provide more context on `Fn` closure modifying binding) - #144529 (Add `#[rustc_pass_indirectly_in_non_rustic_abis]`) - #145915 (Stabilize `fmt::from_fn`) - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool) - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`) - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored) - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`) - #148448 (Update books) - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - #133149 (Provide more context on `Fn` closure modifying binding) - #145915 (Stabilize `fmt::from_fn`) - #145974 (Stabilize -Zno-jump-tables into -Cjump-tables=bool) - #146057 (feat: add `from_fn_ptr` to `Waker` and `LocalWaker`) - #146301 (library: std: sys: net: uefi: tcp: Implement write_vectored) - #148437 (Regression test for undefined `__chkstk` on `aarch64-unknown-uefi`) - #148448 (Update books) - #148451 (tidy: Fix false positives with absolute repo paths in `pal.rs` `check()`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145915 - coolreader18:stabilize-fmt_from_fn, r=dtolnay Stabilize `fmt::from_fn` Resolves #146705, pending its FCP. As discussed in that tracking issue and #117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.

bors · 2025-11-04T06:39:56Z

⌛ Testing commit 93c8bf1 with merge 90b6588...

Kobzol · 2025-11-04T08:38:17Z

@bors r-

Stop bors, this is already merged.

folkertdev · 2025-11-04T11:53:22Z

Seemingly that did not stop bors?

Zalathar · 2025-11-04T12:00:13Z

@bors ping

bors · 2025-11-04T12:00:16Z

😪 I'm awake I'm awake

Zalathar · 2025-11-04T12:00:35Z

@bors r- retry

…, r=dtolnay Stabilize `fmt::from_fn` Resolves rust-lang#146705, pending its FCP. As discussed in that tracking issue and rust-lang#117729, this splits `fmt::from_fn` out from the `debug_closure_helpers` feature.

rustbot assigned thomcc Aug 27, 2025

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 27, 2025

rustbot assigned m-ou-se and unassigned thomcc Aug 27, 2025

coolreader18 closed this Sep 1, 2025

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 1, 2025

This was referenced Sep 17, 2025

Tracking Issue for debug_closure_helpers #117729

Open

Tracking Issue for fmt_from_fn #146705

Closed

coolreader18 reopened this Sep 19, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2025

coolreader18 force-pushed the stabilize-fmt_from_fn branch from 5209f60 to 80851e7 Compare September 19, 2025 18:29

This comment has been minimized.

Sign in to view

coolreader18 force-pushed the stabilize-fmt_from_fn branch from 80851e7 to c14d38d Compare September 22, 2025 18:10

This comment has been minimized.

Sign in to view

coolreader18 added 4 commits September 28, 2025 11:43

Stabilize fmt::{from_fn, FromFn} under feature fmt_from_fn

8537abb

Reword docs slightly

f8d7b41

Remove some feature(debug_closure_helpers) attributes

859ae05

Remove F: Fn bound from FromFn struct

93c8bf1

dtolnay approved these changes Nov 4, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025

Zalathar mentioned this pull request Nov 4, 2025

Rollup of 10 pull requests #148458

Closed

Zalathar mentioned this pull request Nov 4, 2025

Rollup of 9 pull requests #148460

Closed

Zalathar mentioned this pull request Nov 4, 2025

Rollup of 8 pull requests #148462

Merged

bors merged commit 22e4575 into rust-lang:master Nov 4, 2025
10 checks passed

rustbot added this to the 1.93.0 milestone Nov 4, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 4, 2025

coolreader18 deleted the stabilize-fmt_from_fn branch November 4, 2025 22:41

cuviper added the relnotes Marks issues that should be documented in the release notes of the next release. label Jan 9, 2026

rustbot mentioned this pull request Jan 9, 2026

Tracking issue for release notes of #145915: Stabilize fmt::from_fn #150887

Open

Uh oh!

Stabilize fmt::from_fn #145915

Stabilize fmt::from_fn #145915

Conversation

coolreader18 commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 27, 2025

Uh oh!

Kobzol commented Aug 27, 2025

Uh oh!

bors commented Aug 30, 2025

Uh oh!

jmillikin commented Sep 1, 2025

Uh oh!

coolreader18 commented Sep 1, 2025

Uh oh!

coolreader18 commented Sep 1, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bors commented Sep 27, 2025

Uh oh!

dtolnay left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Nov 4, 2025

Uh oh!

bors commented Nov 4, 2025

Uh oh!

Uh oh!

bors commented Nov 4, 2025

Uh oh!

Kobzol commented Nov 4, 2025

Uh oh!

folkertdev commented Nov 4, 2025

Uh oh!

Zalathar commented Nov 4, 2025

Uh oh!

bors commented Nov 4, 2025

Uh oh!

Zalathar commented Nov 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Stabilize `fmt::from_fn` #145915

Stabilize `fmt::from_fn` #145915

coolreader18 commented Aug 27, 2025 •

edited

Loading

dtolnay left a comment •

edited by rustbot

Loading