Add exclude to config.toml #137147

Shourya742 · 2025-02-16T18:00:28Z

Closes: #35678

r? @onur-ozkan

try-job: x86_64-msvc-2

rustbot · 2025-02-16T18:00:37Z

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

bors · 2025-02-18T04:33:42Z

☔ The latest upstream changes (presumably #137176) made this pull request unmergeable. Please resolve the merge conflicts.

config.example.toml

onur-ozkan · 2025-02-23T05:55:17Z

@rustbot author

bors · 2025-02-23T09:03:03Z

☔ The latest upstream changes (presumably #137215) made this pull request unmergeable. Please resolve the merge conflicts.

Shourya742 · 2025-02-24T04:56:53Z

@rustbot review

bors · 2025-02-25T20:30:39Z

☔ The latest upstream changes (presumably #137611) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan

LGTM

onur-ozkan · 2025-03-01T06:17:15Z

@bors r+

bors · 2025-03-01T06:17:17Z

📌 Commit a110552 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T07:22:35Z

@rustbot review
cc: @onur-ozkan

onur-ozkan · 2025-03-01T08:53:02Z

Rebase wasn't required, it was already queued.

Again, @bors r+

bors · 2025-03-01T08:53:05Z

📌 Commit 9206960 has been approved by onur-ozkan

It is now in the queue for this repository.

Shourya742 · 2025-03-01T10:49:29Z

Rebase wasn't required, it was already queued.

Again, @bors r+

I saw change_tracker conflicts on github, so thought of rebasing on latest changes on master. Does bors resolve merge conflicts??

Shourya742 · 2025-03-12T03:21:58Z

@rustbot review

bors · 2025-03-13T14:25:33Z

☔ The latest upstream changes (presumably #138448) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan · 2025-03-15T07:02:17Z

@bors r+

bors · 2025-03-15T07:02:20Z

📌 Commit c6ecd8c has been approved by onur-ozkan

It is now in the queue for this repository.

RalfJung · 2025-03-17T08:08:43Z

src/bootstrap/src/utils/change_tracker.rs

+    ChangeInfo {
+        change_id: 137147,
+        severity: ChangeSeverity::Info,
+        summary: "New option `build.exclude` that adds support for excluding test.",


This should say "excluding tests", right?

Also, it's not just for tests. I missed this. ~~I will send a follow-up PR.~~

PR: #138592

rustbot assigned onur-ozkan Feb 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 16, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from e9a9186 to 2bf009d Compare February 16, 2025 20:06

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 2bf009d to 471069b Compare February 19, 2025 02:42

onur-ozkan reviewed Feb 23, 2025

View reviewed changes

config.example.toml Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from 471069b to daf8f8d Compare February 23, 2025 16:48

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from daf8f8d to a110552 Compare February 27, 2025 14:47

onur-ozkan approved these changes Mar 1, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from a110552 to 9206960 Compare March 1, 2025 07:21

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2025

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from d07eb8b to de54712 Compare March 12, 2025 03:04

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2025

Shourya742 added 5 commits March 13, 2025 21:37

add exclude to config.toml

ad74285

add test for exclude feature

7d1537e

Add change info to change tracker

22571da

make test platform agnostic

9d5f074

update the test_exclude to not use paths with path separators

c6ecd8c

Shourya742 force-pushed the 2025-02-16-support-exclude-in-config.toml branch from de54712 to c6ecd8c Compare March 13, 2025 16:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2025

jieyouxu mentioned this pull request Mar 16, 2025

Rollup of 16 pull requests #138548

Merged

bors merged commit b8c51f4 into rust-lang:master Mar 16, 2025
6 checks passed

rustbot added this to the 1.87.0 milestone Mar 16, 2025

RalfJung reviewed Mar 17, 2025

View reviewed changes

This was referenced Mar 17, 2025

Rollup of 9 pull requests #138595

Merged

Rollup of 12 pull requests #138636

Closed

Shourya742 deleted the 2025-02-16-support-exclude-in-config.toml branch March 29, 2025 01:28

Uh oh!

Add exclude to config.toml #137147

Add exclude to config.toml #137147

Uh oh!

Conversation

Shourya742 commented Feb 16, 2025 • edited by onur-ozkan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 16, 2025

Uh oh!

bors commented Feb 18, 2025

Uh oh!

Uh oh!

onur-ozkan commented Feb 23, 2025

Uh oh!

bors commented Feb 23, 2025

Uh oh!

Shourya742 commented Feb 24, 2025

Uh oh!

bors commented Feb 25, 2025

Uh oh!

onur-ozkan left a comment

Choose a reason for hiding this comment

Uh oh!

onur-ozkan commented Mar 1, 2025

Uh oh!

bors commented Mar 1, 2025

Uh oh!

Shourya742 commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan commented Mar 1, 2025

Uh oh!

bors commented Mar 1, 2025

Uh oh!

Shourya742 commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shourya742 commented Mar 12, 2025

Uh oh!

bors commented Mar 13, 2025

Uh oh!

onur-ozkan commented Mar 15, 2025

Uh oh!

bors commented Mar 15, 2025

Uh oh!

Uh oh!

RalfJung Mar 17, 2025

Choose a reason for hiding this comment

Uh oh!

onur-ozkan Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Shourya742 commented Feb 16, 2025 •

edited by onur-ozkan

Loading

Shourya742 commented Mar 1, 2025 •

edited

Loading

Shourya742 commented Mar 1, 2025 •

edited

Loading

onur-ozkan Mar 17, 2025 •

edited

Loading