Fix alignment description for u64 and f64 in repr-rust.md #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
reviewed
Dec 31, 2025
Comment on lines
11
to
+12
| platform-specific behavior. For example, on x86 `u64` and `f64` are often | ||
| aligned to 4 bytes (32 bits). | ||
| aligned to 8 bytes (64 bits). |
Contributor
There was a problem hiding this comment.
This isn't correct. On some 32-bit x86 targets, the alignment of these are indeed 32-bits. This change also doesn't make sense in the context of the rest of the paragraph, since it is contrasting situations when the alignment is not the same as the size.
Perhaps it would be clearer if it said "on 32-bit x86,".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.