MSRV 1.85, Edition 2024

[clarfonthey]

Includes clippy fixes for methods that were added in the meantime that could be used instead.

I also took the liberty of running taplo fmt in the repo to clean up the TOML files. This is now done in CI.

I've done my best to try and minimise the unsafe block bounds auto-added by fixes as well as possible, but there's a lot of code that needs to be annotated with safety comments anyway, so, some are left with very large unsafe blocks.

Additionally, I have made unreachable_pub now warn by default as agreed upon in #675. With a higher MSRV, we can avoid false positives.

[clarfonthey]

Side note: I hate that you can't lint code that's been cfg'd out. I know that this is nothing new, but it's frustrating that something as simple as unsafe-op-in-unsafe-fn requires downloading multiple builds of libstd, recompiling dependencies for multiple targets, and potentially even downloading separate linking tools for other targets all because of this limitation. I've done it for multiple different cases but this is just the latest one and I'm annoyed about it and going to vent about it here.

Thanks for coming to my talk.

[clarfonthey]

I think at this point, I've implemented all major changes up to the MSRV that I think are important before merging. If I've missed any, please feel free to mention it, although as usual, no rush. I'm not going to have a proper computer to dev this for the next couple days, so, I'll get to any requests when I'm back home unless I happen to notice them before I go to bed tonight.

[Amanieu]

@cuviper Is RHEL still stuck on 1.84? Ideally we would like to directly upgrade to the 2024 edition with a MSRV of 1.85.

[cuviper]

RHEL has 1.88 now.

[Amanieu]

In that case we should be able to just bump to 1.85 and the 2024 edition. It can be done in either this PR or a separate one.

[clarfonthey]

As mentioned, with the unsafe fn lint fixed here, 1.85 is just a difference of cargo fmt, so, it's a quick fix. For the sake of avoiding more rebasing, though, I'll at least do it as a separate commit instead of modifying all of them.

[clarfonthey]

Decided to make this an "optional" check in this script so that people don't need to necessarily have taplo installed to have the script pass, although it will still be enforced on CI, where it will be installed.

[clarfonthey]

That should be everything!