add maybe_write() for lazy data closures on Endpoint and UsbBus#78
Open
mutantbob wants to merge 1 commit intorust-embedded-community:masterfrom
Open
add maybe_write() for lazy data closures on Endpoint and UsbBus#78mutantbob wants to merge 1 commit intorust-embedded-community:masterfrom
mutantbob wants to merge 1 commit intorust-embedded-community:masterfrom
Conversation
Author
|
An example of how it might simplify code that uses USB: mutantbob/imxrt-usbd@05c6584 |
Contributor
|
Wouldn't an |
simpkins
added a commit
to simpkins/usbd-hid-rs
that referenced
this pull request
Apr 9, 2024
This reverts commit c1210a9. (twitchyliquid64#34) This commit breaks the build since it attempts to use `EndpointIn` methods from a PR that were never landed in the usb-device crate: rust-embedded-community/usb-device#78
twitchyliquid64
pushed a commit
to twitchyliquid64/usbd-hid
that referenced
this pull request
Apr 9, 2024
This reverts commit c1210a9. (#34) This commit breaks the build since it attempts to use `EndpointIn` methods from a PR that were never landed in the usb-device crate: rust-embedded-community/usb-device#78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
write()API forEndpointis a little clumsy because it returns an error if the write would block, forcing the code that invokes it to hang on to the buffer and retry later.This is a solution, but it adds method to the
UsbBustrait, forcing downstream implementers to update (see twitchyliquid64/usbd-hid#34 ).I am mostly trying to start a conversation about this so options (such as the ability to check
WouldBlockbefore callingwrite) can be discussed.