Update justfile to only build node and integration_test with the latest feature.
#464
+43
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a feature `latest` to node and integration_test that is the most recent version of bitcoind.
Change the justfile so that there are now two cases: - first are all the crates that can be build with --all-features, - second is the list of crates that cannot and are instead built only with the specified features. node and integration_test are build with the "latest" feature only.
Change update-lock-file script so that there are now two cases: - first are all the crates that can be build with --all-features, - second is the list of crates that cannot and are instead built only with the specified features. node and integration_test are build with the "latest" feature only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeandintegration_testhave individual features for each version ofbitcoind. Enabling all at once makes no sense and caused a hang for a user when updating the lockfiles.latestfeature that is set to the latest version ofbitcoindnodeandintegration_testwith--all-featuresandnodeandintegration_testwith onlylatest. Left as an array so that other features can be added if needed.Closes #361