-
Notifications
You must be signed in to change notification settings - Fork 46
Release tracking PR: bitreq v0.3.0
#459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking PR: bitreq v0.3.0
#459
Conversation
bcc238a to
99482ed
Compare
1c0d3cf to
18b4256
Compare
|
Yep, lets do it. Can you add a changelog entry please. I wrote this up if you want it. # 0.3.0 - 2026-01-16
* Add support for `native-tls` in addition to `rustls` [#451](https://github.com/rust-bitcoin/corepc/pull/451)
* Support connection reuse and clean up `Connection` [#450](https://github.com/rust-bitcoin/corepc/pull/450)
* Make `async` fetching actually async [#448](https://github.com/rust-bitcoin/corepc/pull/448)
* Remove `urlencoding` dependence [#424](https://github.com/rust-bitcoin/corepc/pull/424)
* Remove `punycode` dependency [#423](https://github.com/rust-bitcoin/corepc/pull/423)
* Remove unused `tokio` features [#421](https://github.com/rust-bitcoin/corepc/pull/421)(I changed the title to help me search later for this later down the track.) |
Sadly `Error` has different fields based on different features, so to avoid downstream crates randomly breaking due to unrelated feature flag settings, we need to mark it `non_exhaustive`.
In the future we'd like to support SOCKS proxies as well, so get ahead of it by renaming `Proxy::new` to `Proxy::new_http` to allow us to have a `Proxy::new_socks5` in a point release.
I believe we should go ahead and release bitreq 0.3 with all the changes we made to it, as its a substantial improvement for async clients and now something that could reasonably be used in place of `reqwest` in most cases. There's some remaining proxy issues, but those can be resolved in a point release without API change.
... in Australian time
18b4256 to
b9db614
Compare
|
Okay, rebased and added changelog entries (with some marginal verbiage tweaks) |
tcharding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b9db614
|
BOOM! Thanks man. Tagged and published. |
|
Wohoo, ecosystem migration LFG. If you missed it, breez was looking into using bitreq and it reduced their total binary size by something like 1.5-2.5 MB, which is absolutely insane. |
|
Ah sick, LFG indeed. |
Based on #452 I think its reasonable to release a bitreq 0.3. There's some issues remaining in the proxy code described in #458 but those should be addressable in a point release without API breakage.