1.1.5 #64
Open
1.1.5 #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently SplashCMS table names are not namespaced by any sort of convention. I've added 'cms_' before each of the tables. This helps greatly in integrating with other CFWheels apps and not have table name collisions.
All the 'Cancel' links have been renamed to 'Back to xxx', e.g., 'Back to Layouts' or 'Back to Pages'. The change has been made so to more accurately reflect the behavior of what the user is doing.
So we just check if it exists before using.
When using Custom Tags, for some reason there is a whitespace for every line of CF code. The changes checked in are the most reliable way of fixing that issue.
…ocation
When working with pages/layouts/snippets, especially while developing the first time around, after create and update redirects the user to the index page for pages/layouts/snippets.
This leads to a lot of unnecessary clicking as the user has to edit the page/layout/snippet again.
Also, if you are constant saving your work when you are adding page content, you go back to the page listing. And then have to come back in.
With these changes, you can continue editing till you click on "Back to xxx", e.g., "Back to Pages" or "Back to Layouts" or "Back to Snippets"
Also, changed references for model('categories') to model('category'). This way we use the CFWheels model function to actually call the model component, rather than going directly to the database.
This is done as on *nix systems when they are unzipped, they create folders with mixed case names. And that creates folders that are different from unzipped plugin folders checked in the repo. Ideal solution would be to check in all the unzipped plugin files with the correct casing as generated on a *nix system (which would also work on a Windows box), rather than changing the name of the plugin files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Russ
I've checked in some changes and made the commit comments quite verbose for you to understand what is going on.
Key changes:
Please let me know if you need me to clarify anything.
Thanks for your work.