Skip to content

Make --imageName optional when --templateId is specified #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pantafive wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −5
Open

Make --imageName optional when --templateId is specified #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/pod/createPod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ var CreatePodCmd = &cobra.Command{
Short: "start a pod",
Long: "start a pod from runpod.io",
Run: func(cmd *cobra.Command, args []string) {
if templateId == "" && imageName == "" {
cobra.CheckErr(fmt.Errorf("--imageName is required when --templateId is not specified"))
}
input := &api.CreatePodInput{
ContainerDiskInGb: containerDiskInGb,
DeployCost: deployCost,
Expand Down Expand Up @@ -103,6 +106,5 @@ func init() {
CreatePodCmd.Flags().StringVar(&dataCenterId, "dataCenterId", "", "datacenter id to create in")
CreatePodCmd.Flags().BoolVar(&startSSH, "startSSH", false, "enable SSH login")

CreatePodCmd.MarkFlagRequired("gpuType") //nolint
CreatePodCmd.MarkFlagRequired("imageName") //nolint
CreatePodCmd.MarkFlagRequired("gpuType") //nolint
}
8 changes: 5 additions & 3 deletions cmd/pods/createPods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ var CreatePodsCmd = &cobra.Command{
Short: "create a group of pods",
Long: "create a group of pods on runpod.io",
Run: func(cmd *cobra.Command, args []string) {
if templateId == "" && imageName == "" {
cobra.CheckErr(fmt.Errorf("--imageName is required when --templateId is not specified"))
}
gpus := strings.Split(gpuTypeId, ",")
gpusIndex := 0
input := &api.CreatePodInput{
Expand Down Expand Up @@ -106,7 +109,6 @@ func init() {
CreatePodsCmd.Flags().StringVar(&templateId, "templateId", "", "templateId to use with the pods")
CreatePodsCmd.Flags().StringVar(&volumeMountPath, "volumePath", "/runpod", "container volume path")

CreatePodsCmd.MarkFlagRequired("gpuType") //nolint
CreatePodsCmd.MarkFlagRequired("imageName") //nolint
CreatePodsCmd.MarkFlagRequired("name") //nolint
CreatePodsCmd.MarkFlagRequired("gpuType") //nolint
CreatePodsCmd.MarkFlagRequired("name") //nolint
}