Open
Conversation
This removes the necessity for env being in the path when executing scripts. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
This allows for the tests to succeed, even if there's no such file on the local system. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
It's usually not required to set this at all, except for rare occasions. There are systems out there which don't have a shell/bash in /bin/bash. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
Prefix all calls to executables with /usr/bin/env, or replace them with shell builtins. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
Use standard paths, instead. Signed-off-by: Tom Wieczorek <tom@bibbu.net>
Contributor
sourishkrout
requested changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
Pending BSD/GNU compatibility fix here we can merge this.
It appears tests are failing on Windows now, too. We need to fix this, please.
| LABEL org.opencontainers.image.description="An image to build and test runme." | ||
|
|
||
| ENV HOME=/root | ||
| ENV SHELL=/bin/bash |
Contributor
There was a problem hiding this comment.
Without this Dagger builds will fail. This might very well be an issue in the underlying container image. However, it deserves its own PR to address this because without it downstream pipelines will fail to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATHPrefix all calls to executables with
/usr/bin/env, or replace them with shell builtins. Use an absolute path when dumping the env.This allows for the tests to succeed, even if there's no such file on the local system.
It's usually not required to set this at all, except for rare occasions. There are systems out there which don't have a shell/bash in
/bin/bash.Use standard paths, instead.