Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is primarily a complete refactor of the
CustomEmojiPluginclass. The main goal was to decouple it from other classes. No new features, just extractions of certain parts to make the plugin easier to work with.LifecycleManagerclass andLifecycleinterface to make startup/shutdown of different classes less convolutedEmojiMessageManagerclassSoundojiLoaderandSoundojiPlayerclasses, respectivelyEmojiPanelandNavigationButtonstuff to its ownEmojiPanelManager.CustomEmojiPluginwere just calling stuff in other classes, so the event handlers were moved to be directly in those classes instead.EventBus