Renamed simple-mining-notifier to simple-skilling-notifier

[beegul]

This pull request makes a minor configuration update to the plugins/simple-mining-notifier file. The change adds repository and commit references for tracking purposes.

[runelite-github-app]

Plugin repository has changed

simple-mining-notifier: 4de5b63bacd88deff1b0cd6669f1148da4342535..113590205d170e43c5a5642c56dddce7ac020aa6

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[pajlada]

You're fine to change the repo, and plugin name through the runelite-plugin.properties file in your repo, but you should keep the name of the manifest file in this repo.

[beegul]

You're fine to change the repo, and plugin name through the runelite-plugin.properties file in your repo, but you should keep the name of the manifest file in this repo.

Have reverted the name of the manifest file back to its original name.

[pajlada]

Since you've changed your config group, users who have your plugin installed and have changed the plugin settings will have their settings reset. For the best user experience, we would prefer if you either:
a) kept the config group & config key from before
b) provided an automatic migration for your old users.

Option A is simplest, as it would only require you to change your config group back to simplemining (not a value users will see) and the miningNotify config key back to notifications.

In addition to this, it seems like you've pushed some binary files to the repository in the out directory (seems like there were some other ones there before too). Please remove those from your repository and make sure you don't accidentally add those again (see https://git-scm.com/docs/gitignore).

[beegul]

Since you've changed your config group, users who have your plugin installed and have changed the plugin settings will have their settings reset. For the best user experience, we would prefer if you either: a) kept the config group & config key from before b) provided an automatic migration for your old users.

Option A is simplest, as it would only require you to change your config group back to simplemining (not a value users will see) and the miningNotify config key back to notifications.

In addition to this, it seems like you've pushed some binary files to the repository in the out directory (seems like there were some other ones there before too). Please remove those from your repository and make sure you don't accidentally add those again (see https://git-scm.com/docs/gitignore).

Thanks! Have reverted the config changes to allow for the migration and added the /opt to the .gitignore and removed those files.

beegul/simple-skilling-notifier@1135902