Create bank-slot-sync

[kitten-lissy]

Adds Bank Slot Sync - automatically syncs item variants (recolors, ornament kits, charged items, degraded equipment) to Bank Tag Layout slots.

Features:

• 300+ variant groups covering thousands of OSRS items
• Replace or Adjacent layout modes
• Auto-detects charge variants
• Works with Bank Tags and Bank Tag Layouts plugins

[runelite-github-app]

New plugin bank-slot-sync: https://github.com/kitten-lissy/bank-slot-sync/tree/ed7cc298d053203d7dd562e922031e3060b52875

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[geheur]

• Consider using TabInterface.getActiveTag instead of reading the bank title.
• Why would there be a config item to enable the plugin? Can't people just disable the plugin? Also the "copy variant tags" option also seems like it would be something you'd never want to turn off.
• Also why not just have a low priority subscriber on ScriptPostFired + bankSearch.layoutBank vs this 2 tick wait thing (at least for when a tag tab is active). I don't get what the 2 tick thing is for. why not use bankSearch.layoutBank if a bank tag is currently open? And why wait 2 ticks?

[kitten-lissy]

1. TabInterface.getActiveTag() - Now using this instead of reading the bank title widget. Also added @PluginDependency(BankTagsPlugin.class) and use tabInterface.reloadActiveTab() to refresh the tag view after layout modifications.

2. Config cleanup - Removed the enabled toggle (sorry, that was awk lol) and copyTags (always copies now). Kept removeOldTags as an option since some people may want to keep old item placeholders.

3. Reduced delay to 1 tick - Went from 2 ticks to 1. Still need a single tick for Bank Tags to finish its layout processing before we modify. After processing, reloadActiveTab() refreshes the tag view immediately so users don't need to switch tabs. This is much smoother.

Thank you for the suggestions! This was much easier!!