Update modern-chat #10455
Update modern-chat #10455
Conversation
Classic Mode: - Single "All" tab showing all messages (cleaner layout) - Optional separate PM tabs in classic mode - Optional unread badges in classic mode New Tabs: - Dedicated Game tab for game/system messages - Dedicated Trade tab for trade messages Channel Filters: - Filter button on input box to toggle message types - Filter by: Public, Private, Clan, Friends Chat, Trade, Game, System Spam Integration: - Will properly account for spam filtering - Right-click messages to mark spam/ham - Shares corpus files with SpamFilterPlugin ChatFilterPlugin Support: - Respects message blocking and collapse settings - Duplicate message collapse detection Other: - Set peek source tab via tab right-click menu - Per-tab notification muting via tab right-click menu - Friends Chat kick option (if permitted) - Suppress peek fade at GE option - :: plugin commands now work through overlay - Make the peek overaly respect "Show Npc" configuration - Fix when using the Esc key to close the chat overlay breaking Key Mapping functionality
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
…de the chat bounds with "ClickOutsideToClose" on it would hide the chat
- Timestamps now display in local time - "Start Hidden" setting now works correctly - Fixed chat toggle firing duplicate events - Fixed stale widget references on logout - Fixed chat sizing on login - Fixed NPC dialogs breaking chat display - Fixed chat size refreshes upon legacy chat toggles
Make sure the peek overlay supports message collapsing
|
A lot of important bug fixes and some additional features included. Some issues resolved here are plugin breaking, so it might be good to get this merged ASAP. All my testing is done, everything is stable and ready to go. |
|
if you have plugin breaking bugs you should separate them from the less urgent features if you want them resolved sooner. |
True, I should probably do that now. A lot of these bugs were discovered after I started this update. Although to be fair a lot of these features aren't too impactful, just some UI additions and some more style options, etc. The integration stuff shouldn't be too impactful either I don't think but I'll break them out. |
|
I split out the critical bug fixes from the features |
abextm
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
|
@abextm I removed the PluginManager hack reload code. If you have any suggestions about how I could resolve this issue, it would be greatly appreciated. The way I'd like to solve it is via runelite/runelite#19861 but open to any ideas that isn't what we currently have now (disabling The Key Remapping plugin consumes input events that we need to process before it does with no way of resolving it other than reloading Key Remapping. |
3 participants
Critical Fixes Only
::plugin commands have a workaround for now (restores original chat temporarily)Click Outside ClosesandStart Hiddento reduce chances to have conflicts withKeyRemapperPlugin(not ideal, but no alternative is given right now)If we can get a solution to this issue runelite/runelite#19861 I'll be able to remove the hack fixes for the
KeyRemappingPluginconflicts. This can be done in another update if needed, it shouldn't delay these emergency fixes