Skip to content

Conversation

@DrJacobHolden
Copy link

Fixes ALL circular deps by:

  1. Removing index files
  2. Removing unused imports
  3. Ensuring all type imports use import type
  4. Replace almost all instanceof Player and instanceof Npc checks with isPlayer and isNpc respectively (using the type property rather than class instance comparison so we don't need to circularly reference)

I have lost at least 2 years off my life.

@Katilith Katilith merged commit 4926deb into runejs:develop Feb 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants