RR-583: Create non-nilable CodeTeams.find! #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
approved these changes
Dec 15, 2025
Contributor
martinemde
left a comment
martinemde
left a comment
There was a problem hiding this comment.
looks great and I appreciate the cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements CodeTeams.find!, which is like
CodeTeams.find, except that if the team is not found, a CodeTeams:: TeamNotFoundError exception is raised.The bang version of a method raising exceptions is a common convention in Ruby, and Rails in particular. This is specifically inspired by ActiveRecord, see https://github.com/rails/rails/blob/7ec52e52001bac43688008a9e47de82422582eff/activerecord/lib/active_record/relation/finder_methods.rb#L103-L136
I've added tests for both
.find(there seemed to be none) andfind!. I've also lightly refactored CodeTeams.all and CodeTeams.find to use more idiomatic Sorbet/Ruby implementations. Happy to split those into a separate PR at the reviewer's request or abandon the refactor entirely.