Add specs for all of IO::Buffer constructors #1305
Open
+1,025
−618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #1297
.map. It has a lot of edge cases..forand.string. Not much to say about these, they behave according to documentation and don't have complicated arguments.#initialize(.new).More weird stuff:
.map:offsetguarantees that everything breaks: size is computed incorrectly, crashing VM on reading the whole buffer, on macOS even a bounded read crashes VM, on Windows valid sizes are ???sizecan be larger than file's size, which may somewhat work on some systems or cause crashes on access..new:freeable (GC can still free it, though, I think).