Add allow_control_characters parsing option
#917
Merged
+143
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it's not allowed by the spec, some parsers like Oj do accept it, and it can be blocking a transition. Having this feature can help people migrate.
byroot
force-pushed
the
unescaped-newlines
branch
from
51e0cde to
c629764
Compare
byroot
commented
Dec 11, 2025
|
|
||
| @JRubyMethod(visibility = Visibility.PRIVATE) | ||
| public IRubyObject initialize(ThreadContext context, IRubyObject options) { | ||
| checkFrozen(); |
Member
Author
There was a problem hiding this comment.
cc @etiennebarrie I think that was your JRuby issue. You added checkFrozen in the generated .java file, so it was erased on CI.
Contributor
There was a problem hiding this comment.
Ah nice catch! Thanks for fixing.
Member
There was a problem hiding this comment.
https://github.com/ruby/json/pull/897/files#diff-3b8edc89004b971aeeced1b06ed035d566c91b4b0b883cd71e28d1fee4939c74R825 could probably be enabled on JRuby then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's not allowed by the spec, some parsers like Oj do accept it, and it can be blocking a transition.
Having this feature can help people migrate.