Skip to content

Remove unused variable (and add test for it) #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Dec 17, 2025
Merged

Remove unused variable (and add test for it) #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9f0645
Remove unused variable (and add test for it)
tompng Dec 17, 2025
a3feee4
Fix shadowing outer local variable warning on ruby-2.5
tompng Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/bigdecimal/math.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,9 @@ def erfc(x, prec)
sum = c_prev.add(c_next, prec)

2.step do |k|
c = (c_prev.mult(x, prec) + a * c_next).mult(2, prec).mult(x, prec).div(k, prec)
sum = sum.add(c, prec)
c_prev, c_next = c_next, c
cn = (c_prev.mult(x, prec) + a * c_next).mult(2, prec).mult(x, prec).div(k, prec)
sum = sum.add(cn, prec)
c_prev, c_next = c_next, cn
break if [c_prev, c_next].all? { |c| c.zero? || (c.exponent < sum.exponent - prec) }
end
value = sum.mult(scale.mult(exp(-(x + a).mult(x + a, prec), prec), prec), prec)
Expand Down Expand Up @@ -778,7 +778,6 @@ def lgamma(x, prec)
# if x is close to 1 or 2, increase precision to reduce loss of significance
diff1_exponent = (x - 1).exponent
diff2_exponent = (x - 2).exponent
extra_prec = [-diff1_exponent, -diff2_exponent, 0].max
extremely_near_one = diff1_exponent < -prec2
extremely_near_two = diff2_exponent < -prec2

Expand Down
7 changes: 7 additions & 0 deletions test/bigdecimal/test_bigmath.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ class TestBigMath < Test::Unit::TestCase
MINF = BigDecimal("-Infinity")
NAN = BigDecimal("NaN")

def test_no_warning
assert_separately([], "#{<<~"begin;"}\n#{<<~'end;'}")
begin;
require 'bigdecimal/math'
end;
end

def test_pi
assert_equal(
BigDecimal("3.141592653589793238462643383279502884197169399375105820974944592307816406286208998628034825342117068"),
Expand Down