Refactor test classes #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephannv
commented
Nov 14, 2024
|
|
||
| def view_context = nil | ||
| end | ||
| def phlex(&) |
Contributor
Author
There was a problem hiding this comment.
Renaming from phlex_context to phlex just because it's the same name used in phlex codebase: https://github.com/phlex-ruby/phlex/blob/main/fixtures/sgml_helper.rb#L4
cirdes
approved these changes
Nov 14, 2024
Member
|
Wow this was good! 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating a component test class to make easier to manage tests when we want to change things related to component tests or create another type of tests.