add a CSS fix for leaflet to avoid wider CSS to apply#896
Open
add a CSS fix for leaflet to avoid wider CSS to apply#896
Conversation
CSS conflict happened in Quarto context where a rule on `.legend` was applying to Leaflet own legend box
gadenbuie
reviewed
Dec 8, 2023
Member
There was a problem hiding this comment.
Thanks @cderv! I think we'll wait to see how the upstream issue is resolved first. I'm not completely opposed to this change, but it feels like this might be just one of many issues that arise (even just in leaflet) from Quarto setting text-align: center on the .htmlwidget element.
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Contributor
Author
Agree with that. I did try a PR initially there too, but I suggested also in comment there a specific rule for mermaid (as it seems the rule was added for that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS conflict happened in Quarto context where a rule on
.legendwas applying to Leaflet own legend boxContext of the issue at
fig-s quarto-dev/quarto-cli#7843When adding figure caption for a leaflet in Quarto, this will add some CSS bootstrap rules to the document. One being:
This rules has effect on text inside the leaflet object !
I believe there should be a fix in leaflet CSS so that a default alignment is made on the legend box.
This PR does that.
If this is ok fix with you, question: Should visual test be added ?
If you think this shouldn't be done in leaflet R package, this is also ok. We'll probably add a rule in Quarto to not apply the Figure CSS rules on content under
div.html-widgetobjectsI just figured this could happen in other context without this CSS patch.