Fixed handling non-finite values in colorBin arg domain.#429
Fixed handling non-finite values in colorBin arg domain.#429CreMindES wants to merge 2 commits intorstudio:mainfrom
Conversation
|
Apologies, after reviewing the contents of test-colors.R, I need additional information about the design choices of domain. I can think of two common approaches:
Both of them has their pros and cons, and of course we always try to respect backward compability. |
|
Can you give an example of the case you're trying to fix? |
|
The code below gives that not so nice error message, due to not handled NAs.
I've run into this scenario due to an error while dynamically calculating the domain ( min and max ). |
|
Tamás G. Barna seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
After investigating the special snowflake error message: "Error in if (bins < 2) { : argument is of length zero", it turned out that colorBin does not check for non-finite values in its 'domain' argument.