send mail body as actual body instead of inline attachment

[salim-b]

and rely on mailsend-go's auto-detection of the MIME type

This fixes #55

[rich-iannone]

Thanks for making this PR. The reason for my hesitance before was due to some earlier problems with supplying a long string directly to body. Also, echoing the command line input via echo = TRUE will produce a huge string (which could be truncated, just below https://github.com/rich-iannone/blastula/blob/master/R/smtp_send.R#L269).

With this change, were you able to successfully send test emails that looked as expected?

[salim-b]

With this change, were you able to successfully send test emails that looked as expected?

Yes :)

(I'm using mailsend-go v1.04 on Ubuntu 16.04)

(...) some earlier problems with supplying a long string directly to body. Also, echoing the command line input via echo = TRUE will produce a huge string (which could be truncated (...)

Well, I pass the message to mailsend-go's body option as -file, so the string isn't any longer than it was before with the attach -file option.

When I use blastula::smtp_send(echo = TRUE) I get output like the following:

The command for sending the email message is:

/usr/local/bin/mailsend-go -sub Testing -***.***.ch -port 587 auth -user ***@***.ch -pass ***** -fname Salims MailBot 🤖 -from ***@***.ch -to ***@***.ch body -file /tmp/RtmpP8jiW5/file635241705813.html

The email message was sent successfully.

[rich-iannone]

@salim-b Thanks for your work on this. Sorry to say that we can't use this PR because mailsend-go is no longer used in blastula. Going to close.

[salim-b]

@salim-b Thanks for your work on this. Sorry to say that we can't use this PR because mailsend-go is no longer used in blastula. Going to close.

Yeah, I noticed the switch to curl::send_mail(), which I think makes sense (though I haven't tested it yet).

I guess you're also going to abandon #86 then? Or would you still accept external dependencies if they're completely optional as it is the case with using minify()?