Skip to content

Conversation

@JSerFeng
Copy link
Contributor

rspack 2.0 deprecate experiments.css, should explicitly specifiy the css config, should add a default rule to specify css type

@gemini-code-assist
Copy link

Summary of Changes

Hello @JSerFeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Rspack configuration to align with Rspack 2.0's changes regarding CSS processing. It introduces an explicit default rule for CSS files, ensuring they are correctly handled by the bundler. This change is crucial for maintaining build functionality and compatibility with the newer Rspack version.

Highlights

  • Rspack 2.0 Compatibility: The Rspack configuration has been updated to ensure compatibility with Rspack 2.0, specifically addressing changes in how CSS is processed.
  • Explicit CSS Rule: A new module.defaultRules entry has been introduced to explicitly define the handling of .css files, setting their type to css/auto.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Rspack configuration for compatibility with version 2.0 by adding a default rule for CSS files. The change is correct, but it leaves a deprecated experiments.css configuration in the file. I've suggested removing it to fully complete the update and avoid using deprecated features.

@JSerFeng JSerFeng merged commit d087d3c into main Jan 19, 2026
8 checks passed
@JSerFeng JSerFeng deleted the feat/compat-rspack2.0 branch January 19, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants