As a user, I can see my keywords #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosle
force-pushed
the
feature/create-keyword
branch
from
7f79650 to
594a2e9
Compare
rosle
changed the title
rosle
force-pushed
the
feature/create-keyword
branch
from
12d2f3b to
a91b0b5
Compare
rosle
commented
Mar 31, 2020
| |> Enum.map(&Search.create_keyword(&1, conn.assigns.current_user)) | ||
| end | ||
|
|
||
| defp put_error_flash_for_failed_keywords(create_result, conn) do |
Owner
Author
There was a problem hiding this comment.
I'm displaying some error message when some of the keywords cannot be created but I'm not sure how to test it 🤔💭
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
✅ Create keyword records from the parsed csv file
✅ Associate the keyword to user
✅ Display the keywords
Insight
From the parse keywords, we insert those keywords into the db associated by the user.
Then list all the user keywords on the dashboard page.
Proof Of Work
Now the user can see the keywords on the dashboard.
If some keywords cannot be create (probably there is an error while inserting 🤔). Display an error message - To simulate this I just try to return {:error, changeset} from the create function.