Skip to content

docs: Update collision monitor tutorial for holonomic robot#871

Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom
mach0312:master
Feb 17, 2026
Merged

docs: Update collision monitor tutorial for holonomic robot#871
SteveMacenski merged 2 commits intoros-navigation:masterfrom
mach0312:master

Conversation

@mach0312
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses navigation2 #5740 (ros-navigation/navigation2#5740)
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Updated the VelocityPolygon documentation to reflect the recent logic change for holonomic robots (#5740).
  • Clarified that when holonomic is set to true, linear_min and linear_max checks are applied to the resultant velocity magnitude (speed), not just the x-component.
  • Added a note that for holonomic robots, linear_min and linear_max must be non-negative values.
  • Explicitly stated that for non-holonomic robots (holonomic: false), the behavior remains unchanged, and signed values are still used for backward motion.

Copy link
Collaborator

@mini-1235 mini-1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the precommit and sign with DCO here

@mach0312
Copy link
Contributor Author

Please also fix the precommit and sign with DCO here

Fixed linting issues and signed off all commits. Ready for review.

@SteveMacenski
Copy link
Member

This includes some commits that already exist on main, please fix that so we can review and merge only your changes :-)

Update collision monitor tutorial for holonomic robot

Signed-off-by: Jaerak Son <sjr9017@naver.com>
@mach0312
Copy link
Contributor Author

@SteveMacenski
Apologies for the confusion. I've reset the branch to clean up the history. Now it contains only the relevant changes for this fix. :-)


.. code-block:: yaml

collision_monitor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this come from and does this match the image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created this example following the pattern of the non-holonomic robot example above. regarding the parameters, the previous commit had some discrepancies with the image. I have now updated the angle ranges to match the image exactly.

…tation

- Updated `direction_start_angle` and `direction_end_angle` parameters in YAML to match the reference diagram.
- Refined `using_collision_monitor.rst` based on review feedback (removed redundant non-negative description).

Signed-off-by: Jaerak Son <sjr9017@naver.com>
@SteveMacenski SteveMacenski merged commit 9693282 into ros-navigation:master Feb 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments