Skip to content

fix wrong units & improve explanation for subTree migration#867

Merged
SteveMacenski merged 3 commits intoros-navigation:masterfrom
adivardi:av/bt_subtree
Feb 10, 2026
Merged

fix wrong units & improve explanation for subTree migration#867
SteveMacenski merged 3 commits intoros-navigation:masterfrom
adivardi:av/bt_subtree

Conversation

@adivardi
Copy link
Contributor

@adivardi adivardi commented Feb 9, 2026


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add Doc/Nav2 tickets here #1 or N/A)
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • fix wrong units
  • Clearer explanation in the migration

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the 2x spaces between lines? that makes each its own paragraph which is unnecessarily long.

But otherwise LGTM, no edits to wording

Copy link
Contributor Author

@adivardi adivardi Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.
I left one to separate between the 2 topics of new search directory and unique IDs.

@SteveMacenski SteveMacenski merged commit edff991 into ros-navigation:master Feb 10, 2026
5 of 6 checks passed
@adivardi adivardi deleted the av/bt_subtree branch February 11, 2026 09:56
mach0312 pushed a commit to mach0312/docs.nav2.org that referenced this pull request Feb 12, 2026
…gation#867)

* fix wrong units

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>

* Clearer explanation

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>

* rm some line breaks

---------

Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: Jaerak Son <sjr9017@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments