fix wrong units & improve explanation for subTree migration#867
Merged
SteveMacenski merged 3 commits intoros-navigation:masterfrom Feb 10, 2026
Merged
fix wrong units & improve explanation for subTree migration#867SteveMacenski merged 3 commits intoros-navigation:masterfrom
SteveMacenski merged 3 commits intoros-navigation:masterfrom
Conversation
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
eed5712 to
13bd62b
Compare
Member
There was a problem hiding this comment.
Can you remove the 2x spaces between lines? that makes each its own paragraph which is unnecessarily long.
But otherwise LGTM, no edits to wording
Contributor
Author
There was a problem hiding this comment.
done.
I left one to separate between the 2 topics of new search directory and unique IDs.
SteveMacenski
approved these changes
Feb 10, 2026
mach0312
pushed a commit
to mach0312/docs.nav2.org
that referenced
this pull request
Feb 12, 2026
…gation#867) * fix wrong units Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * Clearer explanation Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * rm some line breaks --------- Signed-off-by: Adi Vardi <adi.vardi@enway.ai> Signed-off-by: Jaerak Son <sjr9017@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points