added is within path tracking bounds condition#815
added is within path tracking bounds condition#815silanus23 wants to merge 4 commits intoros-navigation:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for a new behavior tree condition plugin called "Is Within Path Tracking Bounds Condition" to the plugin index table. To accommodate the longer plugin name, the first column of the condition plugins table is widened from 36 to 46 characters, with all existing rows reformatted accordingly.
Key Changes:
- Added new table row for "Is Within Path Tracking Bounds Condition" with creator Berkan Tali
- Widened first column of the condition plugins table to fit longer plugin names
- Added reference link to the condition's source code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
plugins/index.rst
Outdated
| | | Purnawan | occupied. | | ||
| +----------------------------------------------+--------------------+------------------------+ | ||
| | `Is Within Path Tracking Bounds Condition`_ | Berkan Tali | Checks if robot is | | ||
| | | | within determined | |
There was a problem hiding this comment.
The description "Checks if robot is within determined bounds" is vague and less specific than other entries in the table. Consider clarifying what kind of bounds are being checked. For example: "Checks if robot is within path tracking bounds" or "Checks if robot is within configured tracking bounds".
| | | | within determined | | |
| | | | within path tracking | |
|
@mini-1235 to review Also check out the precommit error. Also add this to the configuration guide / parameter guide (if the BT node has any ports) |
mini-1235
left a comment
There was a problem hiding this comment.
Missing configuration guide + migration guide
Signed-off-by: silanus23 <berkantali23@outlook.com>
Signed-off-by: silanus23 <berkantali23@outlook.com>
Signed-off-by: silanus23 <berkantali23@outlook.com>
Signed-off-by: silanus23 <berkantali23@outlook.com>
9b76b81 to
476382e
Compare
|
https://drive.google.com/drive/folders/1_9RymXihTLZuSZ7DOTpwUuDvpsBrIR5c?usp=drive_link
|
Basic Info
Description of contribution in a few bullet points
I needed to add widen the first column just a liiitle bit. If I should have done it other way I can fix it. @mini-1235