Add more default attachment handlers #106
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two probably quite useful attachment handlers:
Hiddenfor entirely hidden attachmentsOpaquefor attachments that are unimportantIt changes the behavior of
Debug:Debughandler no longer prefers using its display formatter. Formatting a report as{:?}with context/attachments using theDebughandler now prints thefmt::Debugtext.RedactDebughas been added which prefers its display formatter, i.e. redacting the internal information, even when a report is formatted as{:?}.It also introduces the concept of an attachment handler combinator, a simple wrapper type for another handler that adds something extra:
Opaqueis a combinator, but will probably not be used as one very often)Whether any of these are useful enough to belong in the main library is up for debate.