[hist] Assert on zero arguments to Fill
#20836
Open
+59
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and avoid follow-up errors from called functions or LastType by wrapping the remaining body into if constexpr.
siliataider
approved these changes
Jan 9, 2026
Contributor
siliataider
left a comment
siliataider
left a comment
There was a problem hiding this comment.
Nice that it worked!
Test Results 22 files 22 suites 3d 19h 50m 0s ⏱️ Results for commit ec5796e. |
Member
|
I like the clarity of the code and resulting error for the users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and avoid follow-up errors from called functions or
LastTypeby wrapping the remaining body intoif constexpr.