-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[build] Simplify CMake in ATLAS DataVector test directory #19344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Using the `NO_CXXMODULE` option of `ROOTTEST_GENERATE_DICTIONARY` produces dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there are no C++ module neither modulemap produced in the test build directory).
Test Results 22 files 22 suites 3d 18h 25m 47s ⏱️ For more details on these failures, see this check. Results for commit a975161. ♻️ This comment has been updated with latest results. |
dpiparo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for these changes. I am approving the PR, with the caveat that the debian failure perhaps deserves a closer look before merging.
|
Indeed the failure https://github.com/root-project/root/actions/runs/16219472129/job/45796305238?pr=19344#step:11:12437 is worrying It's unclear to me whether it happens because of the changes in this PR. |
The failure on alma9-clang looks real
Using the
NO_CXXMODULEoption ofROOTTEST_GENERATE_DICTIONARYproduces dictionary artifacts that correctly reproduce the ATLAS environment (i.e. there are no C++ module neither modulemap produced in the test build directory).