Add a payload to dispatch events and state changes#9
Open
GrahO23 wants to merge 6 commits intoronaldmannak:masterfrom
Open
Add a payload to dispatch events and state changes#9GrahO23 wants to merge 6 commits intoronaldmannak:masterfrom
GrahO23 wants to merge 6 commits intoronaldmannak:masterfrom
Conversation
Owner
|
Very cool, thanks! What is the rationale behind making the payload parameter mandatory, instead of optional by having two methods (one with a payload parameter, one without). cc @martijnthe |
Author
|
Hi Ronald thanks.
/Graham |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I love YBStatechart, I've had a go at adding payloads to the dispatch and state changes to help avoid storing unnecessary variable outside the state chart.
At least I find it useful for passing params and data between states and transitions.
Don't know if you are interested for master.
Cheers
Graham