[ROMM-2808] Stop filtering nsfw games from search results

[gantoine]

Description
^{Explain the changes or enhancements you are proposing with this pull request.}

Fixes #2808

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR
• I've added unit tests that cover the changes

[gemini-code-assist]

Summary of Changes

Hello @gantoine, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where NSFW games were being filtered out of search results and individual game lookups. By modifying a single API parameter, the change ensures that all games, regardless of their content rating, are now discoverable and retrievable through the system's API, aligning with the intent to stop this specific content filtering.

Highlights

• NSFW Game Filtering Disabled: The pull request disables the filtering of NSFW (Not Safe For Work) games from search results and when retrieving games by ID.
• API Parameter Change: The 'filter' parameter in API calls to the search URL has been changed from 'true' to 'false' in both the 'search_games' and 'get_rom_by_id' functions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request disables NSFW content filtering from Flashpoint search results by changing the filter API parameter from true to false in search_games and get_rom_by_id. The change is correct according to the PR's goal. My review includes a suggestion to make this behavior configurable to provide more flexibility for users, and to address the code duplication of the hardcoded value.

[github-actions]

Test Results

702 tests  ±0   701 ✅ ±0   1m 29s ⏱️ +6s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit fa84ecf. ± Comparison against base commit 6b600dd.

[github-actions]

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
12120	7885	65%	0%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
backend/handler/metadata/flashpoint_handler.py	46%	🟢
TOTAL	46%	🟢

updated for commit: fa84ecf by action🐍