Skip to content

Conversation

@SaraVieira
Copy link
Contributor

Description
This PR adds the ability to edit more metadata by adding a new object called manual_metadata that if set will overthrow other metadata for that specific field

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots (if applicable)

CleanShot 2026-01-02 at 17 36 40 CleanShot 2026-01-02 at 17 36 56

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SaraVieira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant feature allowing users to manually override and manage various metadata fields associated with ROMs. By introducing a dedicated manual_metadata object, the system now provides greater control over how game information is presented, ensuring that user-defined data takes precedence over automatically scraped details. This enhancement improves data accuracy and customization options for users.

Highlights

  • Manual Metadata Field: Introduced a new manual_metadata JSONB column in the roms table to store user-editable metadata.
  • Metadata Prioritization: The roms_metadata view has been updated to prioritize values from manual_metadata over other metadata sources (IGDB, MobyGames, etc.) for fields like genres, franchises, collections, companies, game modes, age ratings, first release date, and average rating.
  • Frontend Editing Component: Added a new AdditionalDetails.vue component to the ROM editing dialog, allowing users to manually input and modify various metadata fields.
  • UI Display Updates: Modified the game details view to correctly display and prioritize manually entered age ratings and YouTube video IDs, including dynamic badge generation for age ratings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ability to manually edit certain metadata fields, which will override data from other sources. The changes are well-implemented across the backend, including a database migration, model updates, and endpoint modifications. The frontend also includes a new UI for editing this metadata. I've identified a few issues in the frontend implementation, primarily concerning reactivity and incorrect business logic, which could lead to bugs or unexpected behavior. My review comments provide specific suggestions to address these points.

@gantoine gantoine self-assigned this Jan 2, 2026
@gantoine gantoine self-requested a review January 2, 2026 17:40
@gantoine gantoine removed their assignment Jan 2, 2026
@SaraVieira
Copy link
Contributor Author

Refetched the types with open api and fixed the TS errors

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great approach! 🔥

@gantoine gantoine merged commit f472c45 into rommapp:master Jan 2, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants