-
-
Notifications
You must be signed in to change notification settings - Fork 320
feature: Add additional editable metadata #2848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @SaraVieira, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant feature allowing users to manually override and manage various metadata fields associated with ROMs. By introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the ability to manually edit certain metadata fields, which will override data from other sources. The changes are well-implemented across the backend, including a database migration, model updates, and endpoint modifications. The frontend also includes a new UI for editing this metadata. I've identified a few issues in the frontend implementation, primarily concerning reactivity and incorrect business logic, which could lead to bugs or unexpected behavior. My review comments provide specific suggestions to address these points.
frontend/src/components/common/Game/Dialog/EditRom/AdditionalDetails.vue
Outdated
Show resolved
Hide resolved
frontend/src/components/common/Game/Dialog/EditRom/AdditionalDetails.vue
Show resolved
Hide resolved
|
Refetched the types with open api and fixed the TS errors |
gantoine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great approach! 🔥
Description
This PR adds the ability to edit more metadata by adding a new object called
manual_metadatathat if set will overthrow other metadata for that specific fieldChecklist
Please check all that apply.
Screenshots (if applicable)