Do not attempt to create a ROM directory on SD2 if SD2 isn't mounted

[julkwiec]

Description
^{Add a check for SD2 mount directory before trying to create a ROMS directory there. Resolves #70}

Checklist
^{Please check all that apply.}

• I've tested the changes locally
• I've updated relevant comments
• I've assigned reviewers for this PR

Screenshots

[gemini-code-assist]

Summary of Changes

Hello @julkwiec, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the filesystem handling logic by preventing the creation of a ROMs directory on the second SD card (SD2) if the SD2 root directory is not detected as mounted. This change improves the application's resilience by avoiding unnecessary file system operations and potential errors in environments where SD2 might not be present or accessible. Additionally, it refactors path constructions for better maintainability.

Highlights

• SD2 ROMs Directory Creation: Introduced a check to ensure the SD2 root path exists before attempting to create the ROMs directory on SD2, preventing errors if SD2 is not mounted.
• Path Construction Refactoring: Refactored the construction of ROMs and catalogue paths for SD1 and SD2 using os.path.join and introduced root path variables for clarity and robustness.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to prevent the creation of a ROM directory on an unmounted SD2 card by adding a check for the mount point. While the intention is correct and the use of os.path.join improves path handling, the current implementation introduces critical issues. Specifically, instance attributes for paths are not always initialized, which will cause an AttributeError. Additionally, a new check can lead to a TypeError if a path variable is None. My review provides specific code suggestions to resolve these bugs by ensuring proper attribute initialization and adding necessary checks for robustness.

[julkwiec]

Reformatted the code & signed the commit to make the checks pass