Skip to content

Conversation

@artursvonda
Copy link

The userEvent better represents actions taken by user/browser and actually allows us to get rid of some hacks.

Also, testing now with React v18.

And removed redundant act calls as well since, both, fireEvent and userEvent wrap calls in act implicitly (when required).

Removes redundant `act` calls as well.
@aroslaniec
Copy link

Love to see this change as it also solves issue with act() wrapping fireEvent() in rse.clear() method that throws RTL warnings - your change seams to be working fine w/o that issue

@kirkobyte
Copy link

I've tested these changes locally on a large codebase I'm migrating to React 18 and can confirm it's fixed bugs which arose from the migration

@chiptus
Copy link

chiptus commented Feb 6, 2024

@romgain do you think this can be merged and published to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants