Normalize line endings in DocumentationGenerator and TestCase to use "\n"#36
Open
ToonDG wants to merge 1 commit intoromanzipp:masterfrom
Open
Normalize line endings in DocumentationGenerator and TestCase to use "\n"#36ToonDG wants to merge 1 commit intoromanzipp:masterfrom
ToonDG wants to merge 1 commit intoromanzipp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm using Windows, but my codebase uses \n line endings, instead of the Windows default of \r\n. Therefore, when running
php artisan model-doc:generate, I get "Failed: ... Can not find class declaration" for each model.Your
DocumentGeneratorfunctionwriteDoc, currently usesPHP_EOLto split the lines. I think it is safer to user\nfor this. In the same function you also split$docblockbyPHP_EOL, but docblock was generated using\n.In this PR I changed
PHP_EOLinto\nin th DocumentatoinGenerator and TestCase.