Update transaction.id_from_pos response for API compliance #1262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building a basic electrum api CLI and testing against my personal
electrsnode, I noticed an issue withblockchain.transaction.id_from_pos:I'm using the
rust-electrum-clientcrate, which expects the JSON key for the TXID to betx_hash, nottx_idas it is now:https://docs.rs/electrum-client/latest/electrum_client/struct.TxidFromPosRes.html
So the deserialization of the response fails. According to the Electrum spec, the key should be
tx_hash, nottx_id:https://electrumx.readthedocs.io/en/latest/protocol-methods.html#blockchain-transaction-id-from-pos
So the electrs implementation is the issue here IMO.
No test added since AFAICT this API isn't exposed via the
electrumCLI tool, and I didn't see another suitable place to add one.Great project btw - excited for the bindex work to get merged!