Configure on server startup and check for settings#9
Open
productiveme wants to merge 5 commits intoromans127:masterfrom
Open
Configure on server startup and check for settings#9productiveme wants to merge 5 commits intoromans127:masterfrom
productiveme wants to merge 5 commits intoromans127:masterfrom
Conversation
Owner
|
That's a good find . I'll test and prep for release. |
Author
|
Any update on this? |
Cloudinary.delete should use public_id instead of publicId
Owner
|
My apologies for the late response. I've been working heavily on getting a few things resolved with the Orion project as a whole. I will try and get this merged by next week. Thank you very kindly for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
In my case I apply the settings a little later than normal (just before Meteor.startup), this pull request will let the server configuration happen on Meteor.startup and check if the settings exist before configuring.