feat(lib): allow x.y versioning scheme for tools #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Rokit strictly required tool versions to follow the `x.y.z` semantic versioning scheme. This would cause parsing errors when a tool in a manifest or a release on GitHub used a simpler `x.y` version, such as `luau@0.683`. This change introduces support for the `x.y` versioning scheme by transparently converting such versions to a compatible `x.y.0` format before they are processed by the `semver` library. This includes: - A new utility function to convert `x.y` version strings to `x.y.0`, correctly handling pre-release tags and build metadata. - Integration of this utility into the parsing logic for `rokit.toml`, `foreman.toml`, and GitHub release tags. - Enhanced the GitHub release fetching logic to first check for the exact tag (e.g., `v1.2.0`) and then fall back to the `x.y` version (e.g., `v1.2`) if the initial tag is not found. This improves compatibility with repositories that use a two-digit versioning scheme for their releases.
Member
|
This needs a changelog entry, but otherwise looks good to me. |
Contributor
Author
I knew i forgot something 🥴 |
Dekkonot
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Rokit strictly required tool versions to follow the
x.y.zsemantic versioning scheme. This would cause parsing errors when a tool in a manifest or a release on GitHub used a simplerx.yversion, such asluau@0.683.This change introduces support for the
x.yversioning scheme by transparently converting such versions to a compatiblex.y.0format before they are processed by thesemverlibrary.This includes:
x.yversion strings tox.y.0, correctly handling pre-release tags and build metadata.rokit.toml,foreman.toml, and GitHub release tags.v1.2.0) and then fall back to thex.yversion (e.g.,v1.2) if the initial tag is not found. This improves compatibility with repositories that use a two-digit versioning scheme for their releases.Solves #86