Skip to content

Conversation

@Dekkonot
Copy link
Member

@Dekkonot Dekkonot commented Aug 14, 2023

Closes #736.

Prevents projects with a data model as a root from being built as a model file and vice versa. Also prevents syncing model files altogether.

This should mitigate a few of the more common problems with building Rojo projects. I'm not sure whether I should revert #691 or not. The check it adds is made moot with this PR, but it could be a good failsafe. Open to suggestion.

This doesn't impact the VSCode extension at all because it determines the file type to build as using a similar heuristic as this PR and listens to errors during serving to display to the user.

@Dekkonot Dekkonot added type: enhancement Feature or improvement that should potentially happen scope: cli Relevant to the Rojo CLI labels Aug 14, 2023
@Dekkonot
Copy link
Member Author

You know, that's on me I didn't think to test whether our own tests would break if we changed this, I will fix it soon:tm:. It is currently 80 degrees and my laptop is hot though, so it'll have to wait.

Copy link
Member

@kennethloeffler kennethloeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that tests were relying on this behavior is pretty funny! 😂

While technically a breaking change, I doubt anyone ever actually intended to do this, or got a working result out of it... so it's probably fine?

@boatbomber
Copy link
Member

Regarding #691, I think leaving that protection in the plugin is still valuable both as a failsafe and as protection against serves from otherwise compatible <=7.3.0 servers.

@Dekkonot
Copy link
Member Author

We can revisit tests later, since I'm not sure on the names of some of these. I want to keep the diff as relevant as possible though, since this turned into a bigger patch than anticipated.

@Dekkonot Dekkonot requested review from boatbomber and kennethloeffler and removed request for kennethloeffler August 20, 2023 19:28
@Dekkonot
Copy link
Member Author

..Apologies for whatever the hell notification that just sent you, Ken. Github's UI isn't intuitive for this.

@Dekkonot Dekkonot requested review from kennethloeffler and removed request for kennethloeffler September 21, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: cli Relevant to the Rojo CLI type: enhancement Feature or improvement that should potentially happen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent building model as a place and vice versa

3 participants