Use post for ref patch and serialize #1192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dekkonot
previously approved these changes
Dec 30, 2025
Member
Author
|
Looks like we need to update tests still (that's my bad), I'll get that done within the next few hours |
Contributor
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
Quenty
added a commit
to Quenty/rojo
that referenced
this pull request
Dec 31, 2025
|
Just saw this! My earlier attempt was more of a quick hotfix so I could iterate really fast, this is such an OP improvement 🕺 |
This was referenced Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1191.
This PR changes the
/api/serialize/and/api/ref-patch/endpoints to use POST and accept a JSON-encoded body containing a list of instance IDs. This allows a far larger amount of IDs to be requested at once (probably as much as memory permits -- I tested up to 400k).